Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Switch from <canvas> to native <progress> element in browser reporter #5113

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 4, 2024 · 1 comment · Fixed by #5015
Closed
3 tasks done
Labels
area: browser browser-specific semver-minor implementation requires increase of "minor" version number; "features" status: accepting prs Mocha can use your help with this one! type: feature enhancement proposal

Comments

@JoshuaKGoldberg
Copy link
Member

Feature Request Checklist

Overview

Filing a backing issue for #5015: right now, the Mocha browser reporter uses a <canvas> element to visualize a progress circle. That's a holdover from when the reporter was written long ago and it was hard to do progress visualizations in CSS.

Suggested Solution

#5015 (comment): Now, many years later, the element is supported in all major browsers. Even IE 10! (which Mocha no longer supports). Proposal: let's remove the canvas altogether, and switch to a full HTML/CSS <progress>?

Alternatives

Maintaining two code paths for the visualization is an extra maintenance burden. Not a fan of the idea.

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: feature enhancement proposal area: browser browser-specific status: accepting prs Mocha can use your help with this one! semver-minor implementation requires increase of "minor" version number; "features" labels Mar 4, 2024
@JoshuaKGoldberg
Copy link
Member Author

#5015 was released in mocha@10.5.0. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific semver-minor implementation requires increase of "minor" version number; "features" status: accepting prs Mocha can use your help with this one! type: feature enhancement proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant