Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Audit and fix accessibility for browser reporter #5129

Open
4 tasks done
JoshuaKGoldberg opened this issue Mar 27, 2024 · 2 comments
Open
4 tasks done

🐛 Bug: Audit and fix accessibility for browser reporter #5129

JoshuaKGoldberg opened this issue Mar 27, 2024 · 2 comments
Labels
area: browser browser-specific status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 27, 2024

Bug Report Checklist

  • I have read and agree to Mocha's Code of Conduct and Contributing Guidelines
  • I have searched for related issues and issues with the faq label, but none matched my issue.
  • I have 'smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, my usage of Mocha, or Mocha itself.
  • I want to provide a PR to resolve this

Expected

There should be no web accessibility issues with the browser reporter.

Actual

A quick axe DevTools scan reveals 3 Elements must meet minimum color contrast ratio thresholds issues.

Minimal, Reproducible Example

See index.html from mochajs/mocha-examples#72.

Versions

Mocha 10.4.0.

Additional Info

This has been an issue for a while. I wanted to wait until after #5113 to bring it up, so as to not get in the way of that PR. 🙂

@JoshuaKGoldberg JoshuaKGoldberg added type: bug a defect, confirmed by a maintainer area: browser browser-specific status: accepting prs Mocha can use your help with this one! labels Mar 27, 2024
@mark-wiemer
Copy link
Contributor

Oh, I can look at this!

@mark-wiemer
Copy link
Contributor

The short answer is that at Microsoft we use Playwright and axe-core for automated a11y testing. We'd have to know what browsers are supported (#5226). The other constraint is that axe-core doesn't simulate user experience, so we'd have to use Playwright to get the page into all the states we'd expect that might have an impact on user experience: all tests passing, some failing, all failing, pending, skipped, etc.

Once automated bugs are fixed (or at least logged) we'd look at manual testing via Accessibility Insights for Web. It's a browser extension that has a ~20-part assessment to go through WCAG 2.1 AA and guide testers through manually checking all parts of a website, including high contrast support, screen readers, and other experiences using assistive technology.

Just noting this for now, not sure if I'll have time to look at things this month, but I haven't forgotten about this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: browser browser-specific status: accepting prs Mocha can use your help with this one! type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants