patch to include uncaught exceptions to error JSON

[ben-bradley]

I found that uncaught exceptions didn't print the stack, only '{ uncaught: true }' so I borrowed shamelessly from base.js to process & include the stack message. I also cleaned up some more of the comma-firsts

[tj]

why change the names? .message and .stack would be better, and without the unrelated style changes would be rad

[ben-bradley]

With a test file like this:

var should = require('should'),
    request = require('request');

describe('simple POST test', function() {
  it('should NOT work', function(done) {
    request.post('http://www.google.com', function(err, res, body) {
      blargh(); // throws uncaught error
      (res.statusCode).should.equal(200);
      done();
    });
  });
});

The blargh(); function throws an uncaught error and all the Error properties (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error#Properties_2) get stripped off of test.err. By renaming them, curiously, they make it through to stdout.

We can keep the names, however, by re-initing the test.err object like this:

// line 38
  runner.on('fail', function(test){
    if (test.err.uncaught && !test.err.generatedMessage) {
      var error = {},
          props = [ 'stack', 'message', 'name', 'fileName', 'lineNumber' ];
      props.forEach(function(prop) {
        error[prop] = test.err[prop];
      });
      test.err = error;
    }
    failures.push(test);
  });

[jbnicolai]

@ben-bradley if you could revert the style changes in lines 6-8 and 27-29 I would be happy to merge this.

[parkr]

@jbnicolai Looks like the style changes have been reverted.

[ben-bradley]

@parkr & @jbnicolai,

It looks like #1295 made some changes that conflict with this one. The solution provided in #1295 is cleaner than this one so I'd go with that, though it did introduce a bug, but #1324 should fix it though.

-Ben

[jbnicolai]

@ben-bradley thanks for your patience and your work on this! Looking at #1324 now.