fixes #1093: missing hooks after failed test with bail #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasilvacontin
changed the title
|
please squash |
|
@travisjeffery Would you call this breaking? |
|
Soz, squashed. |
|
It's a bugfix that doesn't affect the API. People shouldn't be relying on I couldn't find any documentation regarding the behaviour of Waiting for @travisjeffery's opinion. |
|
ping @travisjeffery |
boneskull
added
status: waiting for author
|
👍 it's awesome how the fix was just the omission of one line. |
travisjeffery
pushed a commit
that referenced
this pull request
Nov 27, 2014
fixes #1093: missing hooks after failed test with bail
|
i'd consider this a bugfix/patch. awesome, thanks homies! |
|
Cool! Glad to contribute :) @rstacruz Less code to maintain! |
|
Looks like those changes aren't in latest release yet. Can someone do |
|
ah yep will push a release tonight |
|
@runk, it shipped now with mocha v2.1.0 :) |
|
Awesome 👍 |
boneskull
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1093.
Line
247inlib/runner.js(which was causing the bug) is pointless:419. After finishing the hooks for the current failed test and since no more tests will be executed, no more hooks will be executed in the suite.beforeAllfails, the suite will be ended due to line521.beforeEachfails, runner will proceed withafterEachdue to447. If the suite has bail, no more tests will be ran due to line419and the suite will end.afterEachfails and the suit has bail, the suite will end due to line419.All tests pass after removing the line.
I've also added a test that checks that
afterEachandafterAllhooks are called after a failed test if the suite has bail. I wasn't sure where to add the test, though. Is it good there? Suggestions?