-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1241 #1424
fix #1241 #1424
Conversation
👍 |
@boneskull's 👍 from me, lacks tests, but we've never had them for this case. I prefer to merge this fix now rather than waiting for someone to code the tests. I can commit to create the tests, if there isn't any other happy contributor/volunteer. |
@dasilvacontin If you want to write some tests for the base reporter, that'd be awesome. Since we have none now, I'm not really itchy to merge this immediately. |
Sure, it will be fun. :) Assign #1429 to me and I'll try to get around it during next week. |
@dasilvacontin apparently you cannot assign a ticket to anybody you like; only those with commit access |
Oh, I didn't know. No problemo. |
This PR is waiting on tests. |
I should really get around writing those tests asap. |
I'll need to test this against my diff changes. |
Dang. I'm willing to pass the torch on this one, if anybody wants to code the tests for PS: 🙈 |
@dasilvacontin Don't worry about it, it'll be eviscerated w/ plugin api anyway |
oh, wait, this is a PR. |
@boneskull, yeah, what I'm not so sure is how this plays along with your diff changes, or a rework you made a month/s ago. |
2f458ab
to
2952eca
Compare
I'm going to have to close this due to conflicts. @arBmind thanks for the contribution |
perform stringify only if type is not string