-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for filtering (grep, invert, tags, skipTags) #1475
Conversation
Btw, it there a way to only run tests tagged both with tag 'x' and tag 'y'? |
That's something we talked about early on at #1445, with a special syntax like I think @boneskull's comment was "make it as simple as possible", which I think is nice. So we ended up with It's true that it would be nice, since "run api integration tests" sounds like a common scenario. Another approach could have been # run tests with (api AND integration) OR (app AND integration)
# exclude tests with (unit AND slow) OR (redis)
mocha --tags api,integration --tags app,integration --skip-tags unit,slow --skip-tags redis I'm happy to revisit the PR if the Mocha team thinks it's useful. Good news is there's lots of tests so it should be an easy change 😃 |
I continue discussing at #1445. |
@dasilvacontin I added a new commit (docs only) to show the |
LGTM, though it would be desirable to get a 👍 from either @boneskull or @travisjeffery since I'm not really a maintainer. 😅 |
Haha I didn't know that. Yep will hold off for now! |
Haha, no problemo. Just check for the Collaborator/Owner badge. :) I hope you get an answer soon! |
I'm pretty overloaded atm. Hopefully will have some time next week around xmas to look at stuff. |
don't worry @boneskull! holidays are coming :) |
Happy new year! I'm keen to revive this PR, see what everyone thinks (either the simple |
Fair enough, we can probably revisit this if required. Does this mean any activity on #1445? :) |
Ah, no @rprieto - sorry for the confusion. GH closed this PR as it was directed at the now moved mochajs/mocha#gh-pages branch, which now resides under mochajs/mochajs.github.io#master. I'll tag this for follow-up, and move it over to the new repo as soon as possible. |
And in response to your other question: #1445 is definitely still on my radar. We've been cutting our way through the long-lived PRs for a few days now, and we're down to 17 right now (from 35+ a few days back). So we'll get there :) |
Haha right, no problem then :) Nice work on the PRs! |
Documents the new
--tags
and--skip-tags
options from pull request #1445.