.only patch

[tylerhjones]

patch for describe . only in response to #1481

[dasilvacontin]

I have to test this patch.

[bjornstar]

LGTM, I think that it's a good idea to make describe.only match the behavior of it.only.

[dasilvacontin]

This patch doesn't work (yay our tests). You are only patching one of the interfaces and you are doing it in the compiled mocha file. The compiled mocha file is auto-generated from the lib for the releases.

You have to patch the following files:

• lib/interfaces/bdd.js
• lib/interfaces/qunit.js
• lib/interfaces/tdd.js

[dasilvacontin]

ping @tylerhjones

[tylerhjones]

thanks for the info, ill work on it later tonight MST

[dasilvacontin]

Cool! I was just pinging in case you missed my message.

[tylerhjones]

This currently passes npm test, but I have not yet added a separate test to assert that this .only bug does not appear again.

I was attempting to add the test to test/runner.js but am not sure if that is the correct location or if I am approaching the test correctly.

[dasilvacontin]

The mocha.js file at the root of the repo shouldn't be modified; it is compiled from the source whenever a release is prepared.

Regarding test location, I should suggest adding tests for each of the interfaces at test/acceptance/misc/only.

Please squash your commits into a single one after the changes. Thanks!

[danielstjules]

Thanks for the PR! For issue #1481, it looks like the team has decided to go with #1591 which fixes some related only bugs due to the use of RegExps. Appreciate you taking the time to work on this though!

[Vanuan]

I don't think that fixing multiple issues with one pull request is a good idea.
This is a good PR, it's just missing some tests.

[Vanuan]

#1591 is closed