Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing hook failure behaviour, solves #534 #1531

Closed
wants to merge 1 commit into from
Closed

fixing hook failure behaviour, solves #534 #1531

wants to merge 1 commit into from

Conversation

dasilvacontin
Copy link
Contributor

wip

@dasilvacontin dasilvacontin mentioned this pull request Feb 4, 2015
Closed
@boneskull
Copy link
Contributor

@dasilvacontin Why is this a PR if it's a WIP? 😄

@boneskull boneskull added the status: waiting for author waiting on response from OP - more information needed label Feb 5, 2015
@dasilvacontin
Copy link
Contributor Author

Never mind, I guess I got too excited or something. 😅

@travisjeffery
Copy link
Contributor

i'm fine with it, just put wip in the title or something and make it clear that it's not ready to go. it's a good way to get feedback before wasting a bunch of time on something that's not gonna get in.

@dasilvacontin
Copy link
Contributor Author

@travisjeffery that was my initial intention, to show I'm actively working on it and maybe get some comments, but I'm still trying to figure out stuff. Async errors are being a total mess atm.

@boneskull boneskull removed the status: waiting for author waiting on response from OP - more information needed label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dasilvacontin @boneskull @travisjeffery