Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy/nolazy v8 switch #1900

Closed
wants to merge 1 commit into from
Closed

lazy/nolazy v8 switch #1900

wants to merge 1 commit into from

Conversation

moander
Copy link

@moander moander commented Sep 21, 2015

No description provided.

@danielstjules
Copy link
Contributor

I'd like to avoid adding options like this. Otherwise we risk the same problem we were having with the harmony flags. With node v4, I see over 300 v8 options. Related: #1846 (though it only mentioned harmony flags)

@moander
Copy link
Author

moander commented Sep 22, 2015

It's related to the exposed debug-brk / profiler flags, so I think nolazy should be exposed as well.

@danielstjules
Copy link
Contributor

I agree, would just prefer a solution that accommodates all v8 options rather than slowly building up to a 300+ line long switch.

@moander
Copy link
Author

moander commented Sep 22, 2015

Would it be an acceptable solution to pass all unknown options down to node?

@danielstjules
Copy link
Contributor

#1846 (comment) I think that'd work as a temporary solution :)

@moander moander closed this Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants