Fix #2071: Removed color code to fix Chalk colors

[thedark1337]

Removed extraneous color code that broke output on Windows as shown in #2071

[danielstjules]

I wonder if chalk handles \u001b[0m for us, making resetting to the normal color unnecessary. But I guess given our lack of test coverage around this, it's best to keep the changeset small.

[thedark1337]

From reading the source code of what Chalk uses , it appears to reset already for the open / close. Testing with my mocha tests for my ESLInt config, it seems that is true. Should I remove it as well and amend the commit?

[danielstjules]

Sure, I'll just wanna test with a bunch of reporters prior to giving a thumbs up

[jbnicolai]

From reading the source code of what Chalk uses , it appears to reset already for the open / close

Yeah, having worked on Chalk, I can definitely confirm that is the case. Both the opening and closing escape can be removed.

Should I remove it as well and amend the commit?

Yes please :)

Sure, I'll just wanna test with a bunch of reporters prior to giving a thumbs up
Show all checks

Absolutely! Although I can confidently say that there's no need to do any extra escaping/wrapping around Chalk.

[thedark1337]

Amended the commit to remove the reset code. 👍

[boneskull]

@thedark1337 thanks!