Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle Symbol values in util.stringify() #2094

Merged
merged 1 commit into from
Feb 17, 2016

Conversation

ryym
Copy link
Contributor

@ryym ryym commented Feb 6, 2016

This PR fixes issue #2089.
It enables to generate diff of objects that have Symbol values.

Fixed output:

mocha-symbol-after

@ryym
Copy link
Contributor Author

ryym commented Feb 6, 2016

The cause of this issue is this line of lib/utils.js. According to the MDN document, We have to call toString() explicitly to convert Symbol to string.

@danielstjules
Copy link
Contributor

Looks good, thank you!

danielstjules added a commit that referenced this pull request Feb 17, 2016
handle Symbol values in util.stringify()
@danielstjules danielstjules merged commit ea61d05 into mochajs:master Feb 17, 2016
@ryym ryym deleted the handle-symbol branch February 17, 2016 02:32
@spalger
Copy link

spalger commented Apr 30, 2016

Would love to see this released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants