Report non-match to STDERR and exit if no files are matched #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
suggested changes
Sep 17, 2016
| if (err.message.indexOf('cannot resolve path') === 0) { | ||
| console.error('Warning: Could not find any test files matching pattern: ' + arg); | ||
| return; | ||
| } else { |
There was a problem hiding this comment.
This else is unnecessary.
There was a problem hiding this comment.
Isn't it good practice to re-throw any other error that might not be this specific one? Otherwise it will just be swallowed
There was a problem hiding this comment.
.. And now I get it. Was a bit distracted. Fixed
| }); | ||
|
|
||
| if (files.length === 0) { |
There was a problem hiding this comment.
prefer if (!files.length)
| }); | ||
|
|
||
| if (files.length === 0) { | ||
| process.exit(1); |
There was a problem hiding this comment.
Should probably add an error message here about no files being found, given you can simply execute mocha in a directory with empty subdir test, and this is the current output:
$ mocha
0 passing (3ms)
…if no files are matched at all. Fixes #2194
Munter
force-pushed
the
fix-issue-2194
branch
from
1218f28
to
033f66a
Compare
|
@boneskull Changes implemented, branch rebased and all tests are passing |
boneskull
approved these changes
Sep 18, 2016
|
Thanks @Munter |
1999
pushed a commit
to 1999/mocha
that referenced
this pull request
Sep 19, 2016
…roperty-currentretry * upstream/master: helpful error when necessary suite callback omitted; closes mochajs#1744 Fix an issue and add relevant tests when describe and xdescribe fail when not supplied with a callback (issue mochajs#1744). rename more fixtures; closes mochajs#2383 Report non-match to STDERR and exit if no files are matched (mochajs#2450) Exit process with correct error codes (mochajs#2445) fix test files not using .spec suffix fix test fixtures not using .fixture suffix always halt execution when async skip() called; closes mochajs#2465 (mochajs#2479) avoid test flake in "delay" test; closes mochajs#2469 (mochajs#2470) revert accidental change to bin paths disregard function names when testing under Node.js 6.5.0; closes mochajs#2467 (mochajs#2477) lints more files; add more files to lint check; closes mochajs#2457 adds *.orig to .gitignore Exclude the --inspect flag fix check-leaks to catch a leak whose name begins with 'd'
1999
pushed a commit
to 1999/mocha
that referenced
this pull request
Sep 22, 2016
…-files-cache * upstream/master: attempt windows-friendly reproducible case for mochajs#2315 fix: fix uncaught TypeError if error occurs on next tick, closes mochajs#2315 (mochajs#2439) helpful error when necessary suite callback omitted; closes mochajs#1744 Fix an issue and add relevant tests when describe and xdescribe fail when not supplied with a callback (issue mochajs#1744). rename more fixtures; closes mochajs#2383 Report non-match to STDERR and exit if no files are matched (mochajs#2450) Exit process with correct error codes (mochajs#2445) fix test files not using .spec suffix fix test fixtures not using .fixture suffix always halt execution when async skip() called; closes mochajs#2465 (mochajs#2479) avoid test flake in "delay" test; closes mochajs#2469 (mochajs#2470) revert accidental change to bin paths disregard function names when testing under Node.js 6.5.0; closes mochajs#2467 (mochajs#2477) lints more files; add more files to lint check; closes mochajs#2457 adds *.orig to .gitignore Exclude the --inspect flag fix check-leaks to catch a leak whose name begins with 'd'
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
…2450) * Report non-matching patterns to STDERR and exit with non-zero status if no files are matched at all. Fixes mochajs#2194 * Code review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This displays a warning on STDERR for each glob pattern that is passed in as a binary execution argument if the glob pattern results in no files matched.
If no files are matched across all the passed glob patterns it exits with error code 1
This allows for running tests for any glob pattern that correctly matches files, while still making the user aware of their other invalid glob patterns. Previously we would throw if any pattern did not match any files and the error message was not the best one to figure out the problem.
Fixes #2194