Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #2713 #2714

Closed
wants to merge 1 commit into from
Closed

Fix for issue #2713 #2714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions bin/_mocha
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,12 +466,19 @@ function exitLater (code) {
}

function exit (code) {
var clampedCode = Math.min(code, 255);

// Eagerly set the process's exit code in case stream.write doesn't
// execute its callback before the process terminates.
process.exitCode = clampedCode;

// flush output for Node.js Windows pipe bug
// https://github.com/joyent/node/issues/6247 is just one bug example
// https://github.com/visionmedia/mocha/issues/333 has a good discussion
function done () {
if (!(draining--)) {
process.exit(Math.min(code, 255));
draining--;
if (draining <= 0) {
process.exit(clampedCode);
}
}

Expand All @@ -483,8 +490,6 @@ function exit (code) {
draining += 1;
stream.write('', done);
});

done();
}

process.on('SIGINT', function () {
Expand Down