Adds tests for loading reporters w/ relative/absolute paths

[sul4bh]

@dasilvacontin How does this look for #2772?

[coveralls]

Coverage increased (+0.3%) to 88.501% when pulling 555a90a on sul4bh:master into 73929ad on mochajs:master.

[dasilvacontin]

Great work – thanks! Made some comments.

[dasilvacontin]

Hmm, weird that this works, .cwd() doesn't finish with a / on my computer.

[dasilvacontin]

Could you assert the value of result on both tests? I'm a bit skeptical this works.

[ScottFreeCode]

For the first thing, path.join is real nice in terms of not having to care whether there's already a /.

[sul4bh]

I totally botched the test previously. It looks better now.

[coveralls]

Coverage increased (+0.09%) to 88.277% when pulling bb799c2 on sul4bh:master into 73929ad on mochajs:master.

[dasilvacontin]

True, I thought of that when I saw the '+' concatenation, but I ended up forgetting to comment it. Good catch!

…

On 21 Apr 2017, at 01:49, Scott Santucci ***@***.***> wrote: @ScottFreeCode commented on this pull request. In test/integration/reporters.spec.js: > + + describe('loader', function () { + it('loads a reporter from a path relative to the current working directory', function (done) { + var reporterAtARelativePath = 'test/integration/fixtures/simple-reporter.js'; + + var args = ['--reporter=' + reporterAtARelativePath]; + + run('passing.fixture.js', args, function (err, result) { + assert(!err); + done(); + }); + }); + + it('loads a reporter from an absolute path', function (done) { + // Generates an absolute path string + var reporterAtAnAbsolutePath = process.cwd() + 'test/integration/fixtures/simple-reporter.js'; For the first thing, path.join is real nice in terms of not having to care whether there's already a /. ― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[coveralls]

Coverage increased (+0.09%) to 88.277% when pulling f704aa3 on sul4bh:master into 73929ad on mochajs:master.

[sul4bh]

travis failure is due to a test infrastructure issue.

[ScottFreeCode]

Reran, looks like that passed now.

[dasilvacontin]

LGTM, thanks @sul4bh! ❤️