Fix Travis browser tests dependency #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that fixes Node 0.10 on AppVeyor; if need be, some other fix/workaround can be applied to handle whatever was up with debug without causing this issue
This was referenced Jun 21, 2017
|
This may end up superseded by nodejs/readable-stream#295 and feross/safe-buffer#15 |
|
If we do end up specifying version 2.2.11 or 2.2.x of readable-stream ourselves as this PR does, I'd really prefer a lockfile over this quick hack. I threw this together without trying to figure out how to create a lockfile that uses an older-than-latest version of a dependency for the time it's created, and without waiting to follow up on the recent concerns as to whether lockfiles are workable for Mocha. |
… incompatibilities introduced by 2.3.0 on June 19th
boneskull
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does NOT fix the Sauce 20,000ms disconnect issue.
Does fix the newer issues that appeared just this past day.
This fixes Travis browser tests (except for the Sauce 20,000ms disconnect issue), #2897 fixes AppVeyor Node 0.10 tests; put them both in master and then merge into anything else that's waiting for CI checks to pass, then hope the Sauce 20,000ms issue stays away for a while, ha.
(For the record: the issue is that readable-stream 2.3.0 breaks Phantom 1.x due to use of
Function.prototype.bindand breaks IE7 and 8 due to pulling insafe-buffer, which usesObject.keys.)