Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(index): add missing doc link #3203

Merged
merged 2 commits into from
Jan 17, 2018
Merged

docs(index): add missing doc link #3203

merged 2 commits into from
Jan 17, 2018

Conversation

vkarpov15
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Re: #3135, some of the features on the index page don't have corresponding links. This PR adds a detail link for one of the features.

Alternate Designs

N/A

Why should this be in core?

Docs change

Benefits

More consistent docs and more details re: core features.

Possible Drawbacks

Docs only, no real drawbacks

Applicable issues

@jsf-clabot
Copy link

jsf-clabot commented Jan 15, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.973% when pulling c3bfc58 on vkarpov15/3135 into c7730a6 on master.

Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We're now linting the markdown, which is why Travis-CI is failing. Execute npm run markdownlint to check it.

@vkarpov15
Copy link
Contributor Author

Thanks for the feedback. Linting markdown is super cool, I'm gonna have to borrow that code :)

@boneskull
Copy link
Contributor

@vkarpov15 Can you look into the CLA issue? I think it's a disagreement with your alias

@boneskull boneskull added area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jan 17, 2018
@coveralls
Copy link

coveralls commented Jan 17, 2018

Coverage Status

Coverage remained the same at 89.973% when pulling a71f4f0 on vkarpov15/3135 into c7730a6 on master.

@boneskull
Copy link
Contributor

Travis-CI is having issues.

@boneskull
Copy link
Contributor

LGTM anyway, ty

@boneskull boneskull merged commit f8a1d2a into master Jan 17, 2018
@boneskull boneskull added this to the v5.0.0 milestone Jan 17, 2018
@boneskull boneskull deleted the vkarpov15/3135 branch January 17, 2018 05:26
@vkarpov15
Copy link
Contributor Author

Thanks for merging 👍 looks like the CLA bot says its ok

sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants