fix to exit correctly when using bail flag #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsideris
added
type: bug
marcusmotill
approved these changes
Apr 26, 2018
4 tasks
|
When can we expect the fix to be published? |
|
On our side it hidden failed builds for weeks, so bug seems critical (for now we reverted to |
|
yes please release this |
|
sorry for the unnecessary ping, but also anxious for this fix |
spalger
pushed a commit
to elastic/kibana
that referenced
this pull request
May 18, 2018
spalger
pushed a commit
to elastic/kibana
that referenced
this pull request
May 18, 2018
(cherry picked from commit a5d1f1c)
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 18, 2018
spalger
pushed a commit
to elastic/kibana
that referenced
this pull request
May 18, 2018
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 18, 2018
spalger
pushed a commit
to elastic/kibana
that referenced
this pull request
May 18, 2018
|
published as v5.2.0 |
wopian
referenced
this pull request
in wopian/agc-assembly
May 20, 2018
This Pull Request updates dependency [mocha](https://github.com/mochajs/mocha) from `~5.1.0` to `~5.2.0` <details> <summary>Release Notes</summary> ### [`v5.2.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#​520--2018-05-18) [Compare Source](mochajs/mocha@v5.1.1...v5.2.0) #### 🎉 Enhancements - [#​3375]: Add support for comments in `mocha.opts` ([@​plroebuck]) #### 🐛 Fixes - [#​3346]: Exit correctly from `before` hooks when using `--bail` ([@​outsideris]) #### 📖 Documentation - [#​3328]: Mocha-flavored [API docs](https://mochajs.org/api/)! ([@​Munter]) #### 🔩 Other - [#​3330]: Use `Buffer.from()` ([@​harrysarson]) - [#​3295]: Remove redundant folder ([@​DavNej]) - [#​3356](`https://github.com/mochajs/mocha/pull/3356`): Refactoring ([@​plroebuck]) [#​3375]: `https://github.com/mochajs/mocha/pull/3375` [#​3346]: `https://github.com/mochajs/mocha/pull/3346` [#​3328]: `https://github.com/mochajs/mocha/pull/3328` [#​3330]: `https://github.com/mochajs/mocha/pull/3330` [#​3295]: `https://github.com/mochajs/mocha/pull/3295` [@​plroebuck]: https://github.com/plroebuck [@​harrysarson]: https://github.com/harrysarson [@​outsideris]: https://github.com/outsideris [@​Munter]: https://github.com/Munter --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
4 tasks
This was referenced Oct 5, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 9, 2018
Closed
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The bail flag fixed in #3278, but it doesn't exit correctly when
beforehook throw an error.This PR fix to exit correctly whenever test or hook failed.
Alternate Designs
I don't have any idea.
Why should this be in core?
Now, when
beforehook failed, mocha doesn't exit correctly. It makes bail flag useless.Benefits
Users believe the result of mocha with bail flag.
Possible Drawbacks
I'm not sure.
Applicable issues
Fix #3303