Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CSP(content security policy) #3999

Closed
wants to merge 1 commit into from

Conversation

sconeman
Copy link

Description of the Change

I checked the #3667 issue and add a CSP(content security policy).
The CSP specification is referenced at https://github.com/.
Maybe we need to discuss the CSP specification further.

@jsf-clabot
Copy link

jsf-clabot commented Aug 26, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 92.751% when pulling d46e88b on sconeman:add-csp-to-mochajs-org into f15e988 on mochajs:master.

@craigtaub
Copy link
Contributor

craigtaub commented Aug 31, 2019

Would be really helpful if you could explain in description what each rule is doing. Easier to discuss.

@craigtaub craigtaub added the area: website involving mochajs.org, but not necessarily involving docs label Aug 31, 2019
@Munter
Copy link
Contributor

Munter commented Jul 5, 2020

I'm closing this because its outdated.

My previous experience leads me to not recommend using CSP without also setting up rigorous monitoring and active triaging and handling of all cases. This requires a high level of activity, and I don't think we have the bandwidth to spare on it right now.

If we ever do want to enable CSP on our website we can do so by switching on --contentsecuritypolicy in assetgraph-builder, which will auto generate a policy based on its knowledge of our static assets dependency graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website involving mochajs.org, but not necessarily involving docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants