Fix wrong sponsors images from OC #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
added
area: documentation
|
Great find! |
boneskull
added
the
semver-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #4318 , building our docs are failed with
Error: Unsupported image type. See here or hereOne of our backers(id is
7mywxoz3-409rl6ka-anpvenbd-j7gk85ag)'s avatar URL is https://images.opencollective.com/andréleifeld/97285d0/avatar/32.png. Becauseécharacter in path, cloudflare return blocked HTML page instead avatar image.This HTML page is
Sorry, you have been blocked. You are unable to access opencollective.com. So, the image haspngextension but it is not an image.I'm not sure whether it is needle's problem or cloudflare's problem.
But, we should encode avatar URL before request it.