Fix #4645, Add an extension to _mocha for people with loaders #4647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
Why should this be in core?
It cleanly allows for TS and ESM support, using loaders. A recurring long standing request.
Benefits
ts-node/esm
and other node loaders will work as expected. As well as supporting custom loaders, custom loaders for logging, performance, etc.Possible Drawbacks
If something resolves the symlinks in
.bin/
manually AND looks for a /mocha$/ regex... this would break their code. I don't know any reason to do that and they would using multiple levels of non public APIs, so I'm dismissing this.Applicable issues
#4645