Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of 'growl' notification #4866

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Drop support of 'growl' notification #4866

merged 3 commits into from
Apr 15, 2022

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Apr 9, 2022 •
edited
Loading

Description

Growl is a retired project, see here.

We remove our --growl option and its corresponding notification feature:

  • we have announced this step in Aug/21 and we haven't received any negative user feedbacks.
  • announced migration tests with alternative notification systems as eg. node-notifier have never been undertaken.
  • this nice-to-have feature does not belong into Mocha's core. It's old fashioned, our growl code base is poorly maintained and most IDE offers better reporting options.

@juergba juergba self-assigned this Apr 9, 2022
@juergba juergba added area: usability concerning user experience or interface semver-major implementation requires increase of "major" version number; "breaking changes" type: cleanup a refactor labels Apr 9, 2022
@juergba juergba added this to the v10.0.0 milestone Apr 9, 2022
@juergba juergba marked this pull request as ready for review April 10, 2022 16:23
@juergba juergba merged commit ac81cc5 into master Apr 15, 2022
@juergba juergba deleted the juergba/growl branch April 15, 2022 08:01
@aljones15 aljones15 mentioned this pull request Aug 4, 2022
Closed
@mfranzke mfranzke mentioned this pull request Mar 12, 2023
Draft
76 tasks
@WontonSam WontonSam mentioned this pull request Jun 8, 2024
Open
This was referenced Jul 16, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jul 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Aug 8, 2024
Open
This was referenced Aug 8, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@juergba juergba

Labels
area: usability concerning user experience or interface semver-major implementation requires increase of "major" version number; "breaking changes" type: cleanup a refactor
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@juergba