docs: fix documentation concerning glob expansion on UNIX

[binki]

Fixes #4868.

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• All new code requires tests to ensure against regressions.

Description of the Change

Fix documentation about how shell expansion works on UNIX.

Alternate Designs

I removed incorrect information and added the equivalent correct information. I may have been more verbose than necessary, but it seemed like the documentation was trying to be informative here, so I continued providing the supplemental information.

Why should this be in core?

This is a documentation fix. It removes erroneous information in core which should not be there.

Benefits

The documentation will be less wrong.

Possible Drawbacks

This may result in people being less confused.

Applicable issues

#4868

[juergba]

I agree the docs is incorrect, but I'm not happy with your text either. I'm unsure about your Windows statement since we have countless shells in Windows as eg. git bash, powershell, wsl, cmd, etc. Especially powershell is a pain being so different compared to posix-like shells.
So what the docs should tell (in your own words):

• use quotes to prevent glob expansion by the shell, single/double quotes depending on shell
• it has to be Mocha (via its dependency node-glob) which does the glob expansion
• we recommend double quotes for portability.

Every additional info may be confusing or incorrect, I prefer to not document on shell detail level.

[binki]

we have countless shells in Windows as eg. git bash, powershell, wsl, cmd, etc.

If you shellout in Windows, which is what npm run does, you get CMD. I do not think that will change in the foreseeable future. People who use different shells on Windows are either power users and know what they are doing or are being told to do so by other people who they can ask for help.

[JoshuaKGoldberg]

LGTM, thanks! 🙌

Just one suggestion around a friendlier docs link. What do you think?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: binki / name: Nathan Phillip Brink (ead1635, 7129fbf, ab6bed3, d5c86e2)

[voxpelli]

I would simplify it to:

[You should _always_ quote your globs in npm scripts][article-globbing], the [`node-glob`][npm-glob] module will handle its expansion.

Lets keep additional specifics of shells and os:es out of it.

[binki]

I would simplify it to:

[You should _always_ quote your globs in npm scripts][article-globbing], the [`node-glob`][npm-glob] module will handle its expansion.

Lets keep additional specifics of shells and os:es out of it.

I addressed your changes in the latest commit.

I checked out the article you are referring to and found that it is misleading. It suggests to use single quotes which are unsupported on Windows. If a folder name contains an ampersand (legal on Windows and Unix-like OSes), then the script author might create an expression which succeeds on a Unix-like OS and fails on Windows. So I removed that reference too.

Since the rationale cannot be included, I needed to add instructions to:

• use double quotes
• avoid obvious problem-causing characters within the double quotes

Please consider the latest changes.

[voxpelli]

Better! Thanks 🙏 And thanks for removing the erroneous article.

How would you feel about this minor wording tweak?

[voxpelli]

Thanks @binki 🙏