-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file path to xunit reporter #4985
Conversation
This PR hasn't had any recent activity, and I'm labeling it |
I would like to see this merged, ideally with the Cypress fix I mentioned above... |
Co-authored-by: Ville Lahdenvuo <tuhoojabotti@gmail.com>
This reverts commit 1245e7e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for pressing on this! 🙌
I think we can merge & consider any extra support for Cypress as a followup to discuss separately (is Cypress doing something odd, even wrong?).
Included in v10.4.0 🎉 |
Hi, |
@SophieDel "having trouble" isn't enough details to go off of. Please file a new issue if you think this is a bug or missing feature in Mocha, or if not, see the Mocha Discord for asking for help in its |
@JoshuaKGoldberg thank you ! I will explore further, and file a new issue if needed :) |
Description of the Change
Expose test file path for each test case in the
xunit
reporter.Alternate Designs
Why should this be in core?
The test file path was already added to other reporters in this PR:
It seems the file path can be added to each reporter as needed.
Benefits
Possible Drawbacks
Applicable issues
None.
This should be part of a minor release as an enhancement.
I submitted this last year as #4885 but heard no response. I am recreating the same PR now after hearing interest in it in this comment: #4885 (comment)
Fixes #5112.