fix: support errors with circular dependencies in object values with --parallel #5212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
breakCircularDeps
breaks the reporter inparallel
mode withallow-uncaught
#5188; fixes 🐛 Bug: infinite loop in parallel tests with uncaught error containing circular dependency #5209status: accepting prs
Overview
Only calling
breakCircularDeps
onresult.error
means any circular references in other properties ofresult
still go through.SerializableEvent._serialize
can generally visit them fine, but they still end up being infinitely added topairs
. This PR adds aseenPairs
Set
to make sure they only get serialized once each. This fixes #5209.Also only writes to properties with
.writable
object descriptors. This fixes #5188.