-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use accurate test links in HTML reporter #5228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Steps in CONTRIBUTING.md were taken
I don't think they were 🙂. From that doc:
- Please file an issue using the feature request template if you have a change to propose, including a bugfix.
- Unit and/or integration tests are required for any code change.
As maintainers looking at this PR, we don't know what bugs you're suggesting this PR will fix, why it fixes them, or what test cases would be needed to enforce that they stay fixed. I appreciate the drive to improve things in Mocha (thanks!) but please follow the contributing guide. Switching to a draft PR in the meantime.
It should already be quite clear in the Overview section as well as in the commit message: this PR is to fix inaccurate test links for the HTML reporter, such as clicking on a link for As for tests: this is a UI-related change and I wonder how and what test you would like it to be? Look back the commit history, many previous changes about the reporter didn't have related tests, such as e263c7a. If you really want a test then I think it either has to be run manually, or you'd have to implement a whole ecosystem for headless-browser related tests. |
- Add '^' and ' ' for a suite link so that a link for `Case1` won't hit `Case10 test1`. - Add '^' and '$' for a test link so that a link for `CSS` won't hit `should fix invalid CSS`.
6d7782a
to
7078d11
Compare
Thanks for filing the issue + linking, this makes a lot more sense to me now. Agreed on the bug and marked as accepting PRs! 🚀 👍 on the HTML reporter not having existing tests, so it's fine to omit tests for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 works great, thanks!
I also tried with emojis like 🍎 and it worked with them.
PR Checklist
status: accepting prs
Overview
Fix inaccurate suite/test links that may hit unrelated tests:
Case1
won't hitCase10 test1
.CSS
won't hitshould fix invalid CSS
.