Only skip current suite if error in beforeEach or beforeAll [Fix #581]

[dansitu]

A failed beforeEach or beforeAll hook will now only cause the current suite to be skipped, rather than terminating the entire run.

Fix for #581

[tj]

this seems to mostly work, however if you have a beforeEach the nested suites will still execute beforeEach, even though a parent one has failed, ill see if i can get that working quickly here

[dansitu]

Oops - sorry, good catch.

On Nov 28, 2012, at 4:08 PM, TJ Holowaychuk notifications@github.com wrote:

this seems to mostly work, however if you have a beforeEach the nested suites will still execute beforeEach, even though a parent one has failed, ill see if i can get that working quickly here

—
Reply to this email directly or view it on GitHub.

[piuccio]

@dansitu Any update on this pull request?

I'm having an issue writing my custom reporter because when there's an error inside hooks, the runner doesn't emit the hook end event.

[dansitu]

I was in a hurry and didn't have time to make the fix @visionmedia suggested. @piuccio, maybe you'll have better luck?

[piuccio]

I'll see if I can work on it

[nbrownus]

Any reason to not just blow away the children suites of the current suite when failHook is called?

Runner.prototype.failHook = function(hook, err){
  this.fail(hook, err);
  this.suites.suite = [];
  this.emit('hook end', hook);
 };

This solves for the issue with beforeEach and nested suites.

[travisjeffery]

fixed by #1043