Added deferred execution support #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why it reports build failure. Locally all tests pass for me. |
|
Turns out I was running 'make test' instead of 'make test-all'. The last commit introduces a few changes to the Runner class but fixed what was broken in the previous commit. |
This function signals mocha to pause processing files while tests are generated asynchronously. For this to work, a few changes were required in the Mocha and Runner classes: - In the Mocha class, the 'loadFiles' method was refactored to work asynchonously. - In the Runner class, the globals initialization was moved out of the constructor into a new method: 'initDefaultGlobals'. This method needs to be invoked prior to running the tests, so the runner will take a 'snapshot' of the global properties. This commit should also solve issue mochajs#362
|
👍 |
|
@tarruda, sorry for the long silence on this. I appreciate the effort, but believe this is no longer of interest to Mocha. If you feel this PR is still relevant, feel free to comment :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve issue #362.
A global 'wait' function is added so the test files can pause mocha processing and generate
tests asynchronously. The function returns a semaphore with a single method 'resume' to continue processing test files.