Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation in clean utility #761

Merged
merged 1 commit into from
Dec 7, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,11 +193,13 @@ exports.slug = function(str){

exports.clean = function(str) {
str = str
.replace(/\r\n?|[\n\u2028\u2029]/g, "\n").replace(/^\uFEFF/, '')
.replace(/^function *\(.*\) *{/, '')
.replace(/\s+\}$/, '');

var spaces = str.match(/^\n?( *)/)[1].length
, re = new RegExp('^ {' + spaces + '}', 'gm');
, tabs = str.match(/^\n?(\t*)/)[1].length
, re = new RegExp('^\n?' + (tabs ? '\t' : ' ') + '{' + (tabs ? tabs : spaces) + '}', 'gm');

str = str.replace(re, '');

Expand Down
59 changes: 59 additions & 0 deletions test/acceptance/utils.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
var utils = require('../../lib/utils');

describe('lib/utils', function () {
describe('clean', function () {
it("should format a single line test function", function () {
var fn = [
"function () {"
, " var a = 1;"
, "}"
].join("\n");
utils.clean(fn).should.equal("var a = 1;");
});

it("should format a multi line test indented with spaces", function () {
// and no new lines after curly braces, shouldn't matter
var fn = [
"function(){ var a = 1;"
, " var b = 2;" // this one has more spaces
, " var c = 3; }"
].join("\n");
utils.clean(fn).should.equal("var a = 1;\n var b = 2;\nvar c = 3;");
});

it("should format a multi line test indented with tabs", function () {
var fn = [
"function (arg1, arg2) {"
, "\tif (true) {"
, "\t\tvar a = 1;"
, "\t}"
, "}"
].join("\n");
utils.clean(fn).should.equal("if (true) {\n\tvar a = 1;\n}");
});

it("should format functions saved in windows style - spaces", function () {
var fn = [
"function (one) {"
, " do {",
, ' "nothing";',
, " } while (false);"
, ' }'
].join("\r\n");
utils.clean(fn).should.equal('do {\n "nothing";\n} while (false);');
});

it("should format functions saved in windows style - tabs", function () {
var fn = [
"function ( ) {"
, "\tif (false) {"
, "\t\tvar json = {"
, '\t\t\tone : 1'
, '\t\t};'
, "\t}"
, "}"
].join("\r\n");
utils.clean(fn).should.equal("if (false) {\n\tvar json = {\n\t\tone : 1\n\t};\n}");
});
});
});