-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
show users how to run a test by pointing to the local install of mocha
show users how to set up their npm test script to use mocha
|
||
```json | ||
"scripts": { | ||
"test": "./node_modules/mocha/bin/mocha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm script implicitly have node_modules/.bin
in $PATH
. It's enough to just write "mocha"
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. I committed that change to the PR.
npm has ./node_modules/.bin in path, so calling the module works fine.
@bdharris08 Thanks. Can you please sign the CLA? |
I'll implement this myself later this evening if the CLA in this or #53 is not signed; this causes a lot of confusion |
I should have read the contributing guide, sorry for the confusion. If a merge is needed I'll do it. |
@bdharris08 There's no up-to-date contributing guide for Mocha (yet), though it's in progress: #61 Thanks! |
@boneskull Ok, I signed the CLA. Checked on #53 and it's essentially the same change except for the npm test script in the package.json. Let me know if you would like any other changes. |
Sorry for not responding...thanks for making the change; much better now. 👍 |
#57
Open to changes.