Skip to content
This repository has been archived by the owner on Jan 4, 2018. It is now read-only.

Getting started run test #58

Merged
merged 4 commits into from
Nov 2, 2016
Merged

Getting started run test #58

merged 4 commits into from
Nov 2, 2016

Conversation

bdharris08
Copy link
Contributor

#57

Open to changes.

show users how to run a test by pointing to the local install of mocha
show users how to set up their npm test script to use mocha

```json
"scripts": {
"test": "./node_modules/mocha/bin/mocha"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm script implicitly have node_modules/.bin in $PATH. It's enough to just write "mocha" here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks. I committed that change to the PR.

npm has ./node_modules/.bin in path, so calling the module works fine.
@boneskull
Copy link
Contributor

@bdharris08 Thanks. Can you please sign the CLA?

@boneskull boneskull mentioned this pull request Nov 1, 2016
@boneskull
Copy link
Contributor

I'll implement this myself later this evening if the CLA in this or #53 is not signed; this causes a lot of confusion

@bdharris08
Copy link
Contributor Author

I should have read the contributing guide, sorry for the confusion. If a merge is needed I'll do it.

@boneskull
Copy link
Contributor

@bdharris08 There's no up-to-date contributing guide for Mocha (yet), though it's in progress: #61

Thanks!

@bdharris08
Copy link
Contributor Author

@boneskull Ok, I signed the CLA. Checked on #53 and it's essentially the same change except for the npm test script in the package.json. Let me know if you would like any other changes.

@boneskull boneskull merged commit 57dfe4f into mochajs:master Nov 2, 2016
@bdharris08 bdharris08 deleted the getting-started-run-test branch November 2, 2016 02:50
@STRAYKR
Copy link

STRAYKR commented Nov 18, 2016

Sorry for not responding...thanks for making the change; much better now. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants