Properly receive websockets frames when using ssl #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test for this would be awesome, as it would make it obvious how to reproduce the issue and prevent this from happening again. |
|
You would need a websocket client library for the test... |
|
Plus it's very easy to reproduce: Just create an ssl websocket and access it with a browser, plus send some data to it from the browser, and your websocket process instantly terminates. |
|
Are you going to merge this or fix it yourself, or do you simply not care about websocket security? |
|
I'm not going to merge this until there's some sort of test. I may write one myself, eventually, but I have other priorities this holiday season. Most people terminate SSL at some sort of load balancer and not directly with mochiweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that websocket packets sent from the client to the mochiweb server are not received when using SSL websockets. I've added some code that seems to fix it...