Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verifyZeroInteractions? #446

Closed
rashadsookram opened this issue Oct 8, 2021 · 1 comment · Fixed by #447
Closed

Remove verifyZeroInteractions? #446

rashadsookram opened this issue Oct 8, 2021 · 1 comment · Fixed by #447

Comments

@rashadsookram
Copy link
Contributor

I was trying to update to Mockito 4, and I noticed that I was getting NoSuchMethodErrors when using Mockito-Kotlin's verifyZeroInteractions.

After looking into it, it turns out that this was happening because Mockito.verifyZeroInteractions was removed as of Mockito 4, and Mockito-Kotlin hasn't been updated to build against Mockito 4 yet. I also noticed that verifyZeroInteractions has been marked as deprecated in Mockito-Kotlin, but there hasn't been a new release since then.

If there are plans of releasing a Mockito-Kotlin 4 soon, maybe verifyZeroInteractions can be removed? Or if there's going to be another update for 3.x first, maybe the implementation of verifyZeroInteractions can be changed to call through to verifyNoMoreInteractions instead, so that it's usable (but still deprecated) with Mockito 4?

@TimvdLippe
Copy link
Contributor

Ah yes, we should remove it from mockito-kotlin as well. Do you mind sending us a PR?

rashadsookram added a commit to rashadsookram/mockito-kotlin that referenced this issue Oct 8, 2021
rashadsookram added a commit to rashadsookram/mockito-kotlin that referenced this issue Oct 8, 2021
rashadsookram added a commit to rashadsookram/mockito-kotlin that referenced this issue Oct 8, 2021
TimvdLippe pushed a commit that referenced this issue Oct 8, 2021
This also removes `verifyZeroInteractions`, which was removed in Mockito 4.

Fixes #446.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants