Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate standalone kani, add support for cargo-kani for every call #46

Merged
merged 5 commits into from
Mar 16, 2023

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Mar 10, 2023

Description of changes:

Switch to cargo-kani for all commands, and deprecate usage of standalone kani.

Call-outs:

Need to raise an issue or call out in documentation that we don't support standalone kani as a proof runner i.e we require that the extension be run on a crate with a declared cargo.toml. This is similar to how rust-analyzer handles it too, rust-lang/rust-analyzer#8818.

Testing:

  • How is this change tested? Manual testing

  • Is this a refactor change? Yes

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense for the extension to only use cargo kani commands, but I have a few questions.

tsconfig.json Outdated Show resolved Hide resolved
src/model/kaniCommandCreate.ts Outdated Show resolved Hide resolved
src/model/kaniRunner.ts Outdated Show resolved Hide resolved
@jaisnan jaisnan requested a review from adpaco-aws March 16, 2023 20:14
Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jaisnan !

@adpaco-aws adpaco-aws merged commit c980d26 into model-checking:main Mar 16, 2023
@jaisnan jaisnan deleted the cleanup-execution branch March 17, 2023 12:19
@jaisnan jaisnan restored the cleanup-execution branch March 31, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants