Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualization process #50

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Mar 31, 2023

Description of changes:

The visualization process was still using exec to do the process spawning and needed to be replaced with execFile.
It adds shell=false, which was missing, and now doesn't spawn a new shell for execFile.

Testing:

  • How is this change tested? Manually

  • Is this a refactor change? Yes

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

src/ui/reportView/callReport.ts Outdated Show resolved Hide resolved
src/ui/reportView/callReport.ts Outdated Show resolved Hide resolved
@jaisnan jaisnan merged commit d34a4e8 into model-checking:main Mar 31, 2023
@jaisnan jaisnan self-assigned this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants