Ensure cargo-kani setup is idempotent #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
approved these changes
May 12, 2022
adpaco-aws
reviewed
May 12, 2022
| @@ -107,6 +107,7 @@ jobs: | |||
| docker run -w /tmp/kani/tests/cargo-kani/simple-lib kani-latest cargo kani | |||
| docker run -w /tmp/kani/tests/cargo-kani/simple-visualize kani-latest cargo kani | |||
| docker run -w /tmp/kani/tests/cargo-kani/build-rs-works kani-latest cargo kani | |||
| docker run kani-latest cargo-kani setup --use-local-bundle ./kani-latest-x86_64-unknown-linux-gnu.tar.gz | |||
There was a problem hiding this comment.
Suggested change
| docker run kani-latest cargo-kani setup --use-local-bundle ./kani-latest-x86_64-unknown-linux-gnu.tar.gz | |
| docker run kani-latest cargo-kani setup --use-local-bundle ./kani-latest-x86_64-unknown-linux-gnu.tar.gz |
There was a problem hiding this comment.
They all do, I was trying to keep the "command run in the container" more separate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Quick fixes for lack of idempotency in
cargo-kani setupResolved issues:
Resolves #1156
Call-outs:
ln -s--use-local-bundlecode. I changed this to directly extract the bundle to the correct location in the first place, making its effective behavior more like the download case.canonicalizecan fail if the file doesn't exist. Print the file before canonicalizing.Testing:
How is this change tested? A re-install test added to the release bundle tests
Is this a refactor change? no
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.