Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit for copysignf* #1249

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Audit for copysignf* #1249

merged 3 commits into from
Jun 6, 2022

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Restores and completes the audit for copysignf32 (copysignf) and copysignf64 (copysign) with one test for each intrinsic.

Resolved issues:

Part of #1163

Call-outs:

Testing:

  • How is this change tested? Adds 2 tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner June 3, 2022 20:31
danielsn
danielsn approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@danielsn danielsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests

@adpaco-aws adpaco-aws merged commit c5c4d5f into model-checking:main Jun 6, 2022
@adpaco-aws adpaco-aws mentioned this pull request Jun 15, 2022
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsn danielsn danielsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adpaco-aws @danielsn