Audit for floorf*
#1265
Merged
Audit for floorf*
#1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
reviewed
Jun 8, 2022
| #[kani::proof] | ||
| fn test_one() { | ||
| let one = 1.0; | ||
| let ceil_res = unsafe { floorf32(one) }; |
There was a problem hiding this comment.
note: calling things ceil_res here. I'd be in favor of just using result here
There was a problem hiding this comment.
Done! Also renamed the "towards" function to test_towards_neg_inf. Thanks!
tedinski
approved these changes
Jun 8, 2022
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Restores and completes the audit for the
floorf32(floorf) andfloorf64(floor) intrinsics.Resolved issues:
Part of #1163
Part of #1025
Call-outs:
Testing:
How is this change tested? Adds 2 tests, removes 2 tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.