Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for rintf* and nearbyintf* intrinsics #1277

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Restores and completes the audit for the rintf32 (rintf), rintf64 (rint), nearbyintf32 (nearbyintf) and nearbyintf64 (nearbyint) intrinsics.

Resolved issues:

Part of #1163
Fixes #1025

Call-outs:

I've tried to add comments regarding things that may be confusing. Please let me know if something's not clear and I'll add more.

Testing:

  • How is this change tested? Adds 4 tests, removes 4 tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner June 14, 2022 00:22
@adpaco-aws
Copy link
Contributor Author

Updated all tests to require diff <= 0.5 (instead of diff < 1.0) as we do for roundf* intrinsics, and renamed the roundf* test functions.

@adpaco-aws adpaco-aws merged commit 252c1ce into model-checking:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding intrinsics are not working
2 participants