Fix compilation of panic!() when the arg is another macro. #1407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In rust, a macro cannot expand another macro that was given as an argument. However, some of the std macros are expanded inside the compiler, which gives them a way around that.
Because we implement those macros are regular macros, we cannot expand other macros and we also cannot limit the first argument to be a literal.
I decided for now to just relax what we accept as the first argument.
Resolved issues:
Resolves #1386
Call-outs:
This solution us to accept whatever the std panic!() macro accepts, but it may accept invalid things as well, such as:
That was already accepted as the other arguments of these macros, so I don't think this is big step back. This also won't impact soundness since whatever issue that could rise from creating the expression is inside a panic statement; thus verification has failed already.
Testing:
How is this change tested? New test + old tests.
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.