Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable calling --slice-formula by default with conditional flags. #1479

Merged

Conversation

jaisnan
Copy link
Contributor

@jaisnan jaisnan commented Aug 9, 2022

Description of changes:

Hot fix for disabling CBMC's --slice-formula. --slice-formula was being called by default which led to some unnecessary values being presented in the trace. This PR disables the CBMC flag when calling --visualize or when we run Kani with --no-slice-formula.

Resolved issues:

Resolves #1288

Call-outs:

Since the fix is a just conditionally enabling a flag, no tests are necessary imo. Calling Cargo Kani with --dry-run reveals that --slice-formula is disabled when calling --visualize or --no-slice-formula.

A test would be more expensive than is needed.

Testing:

  • How is this change tested?
    Checked with dry-run if the extra flag is still being called.

  • Is this a refactor change?
    Yes

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@jaisnan jaisnan requested a review from a team as a code owner August 9, 2022 02:38
@tedinski
Copy link
Contributor

tedinski commented Aug 9, 2022

If you fix the minor formatting error quickly, we can probably get this in before release today.

@jaisnan jaisnan merged commit 075e7bd into model-checking:main Aug 9, 2022
@jaisnan jaisnan deleted the issue-1288-disable-slice-formula branch August 9, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slice-formula is enabled unconditionally, but should not be used when getting traces
2 participants