Disable calling --slice-formula
by default with conditional flags.
#1479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Hot fix for disabling CBMC's
--slice-formula
.--slice-formula
was being called by default which led to some unnecessary values being presented in the trace. This PR disables the CBMC flag when calling--visualize
or when we run Kani with--no-slice-formula
.Resolved issues:
Resolves #1288
Call-outs:
Since the fix is a just conditionally enabling a flag, no tests are necessary imo. Calling Cargo Kani with
--dry-run
reveals that--slice-formula
is disabled when calling--visualize
or--no-slice-formula
.A test would be more expensive than is needed.
Testing:
How is this change tested?
Checked with dry-run if the extra flag is still being called.
Is this a refactor change?
Yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.