Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cadical to the list of available solvers #2217

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

With the upgrade to CBMC 5.77.0 which is shipped with CaDiCaL that can be selected with --sat-solver cadical, add cadical as a valid argument to the --solver option and the kani::solver attribute.

Resolved issues:

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Added two tests

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner February 17, 2023 18:34
Copy link
Contributor

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@zhassan-aws zhassan-aws marked this pull request as draft February 17, 2023 21:07
@zhassan-aws
Copy link
Contributor Author

Cadical didn't get included in CBMC's macos package. Turning this into a draft till this is addressed.

@zhassan-aws
Copy link
Contributor Author

CBMC tracking issue: diffblue/cbmc#7555

@zhassan-aws zhassan-aws marked this pull request as ready for review March 3, 2023 18:57
@zhassan-aws zhassan-aws merged commit c408045 into model-checking:main Mar 3, 2023
@zhassan-aws zhassan-aws deleted the solver-cadical branch March 3, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants