Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo #2194 #2276

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Undo #2194 #2276

merged 3 commits into from
Mar 7, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

The PR that fixed #2187 (#2194) broke #1949. Opening this PR to undo #2194 until we find a more reliable approach to fix #2187 (tracked by #2275).

Resolved issues:

Resolves #1949
Reopens #2187

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Added a new test

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner March 7, 2023 17:37
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to also add a small test that reproduces this issue?

@zhassan-aws
Copy link
Contributor Author

Are you able to also add a small test that reproduces this issue?

Do you mean the issue in #1949? If so, I did add a small test in my previous fix for it (see #2005), but turns out that the test doesn't fully reproduce the issue in the chrono crate (because it didn't fail in #2194), and so this time, I decided to add a test with the chrono crate itself.

@zhassan-aws zhassan-aws enabled auto-merge (squash) March 7, 2023 20:03
@zhassan-aws zhassan-aws disabled auto-merge March 7, 2023 20:04
@zhassan-aws zhassan-aws enabled auto-merge (squash) March 7, 2023 22:37
@zhassan-aws zhassan-aws merged commit 36d9c38 into model-checking:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants