Add "kani" configuration key to enable conditional compilation in build scripts #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one issue with this change is that we require nightly cargo since this is a unstable feature. However, we invoke whatever cargo is in the system. I.e.: I'll need to change our code to invoke the cargo we install. |
karkhaz
approved these changes
Apr 3, 2023
karkhaz
requested review from
karkhaz and
a team
and removed request for
karkhaz
Also add support to the playback command and use a script to test the fix. Inside the Kani test folder, rustup will pick up the version from our toolchain configuration file.
celinval
force-pushed
the
issue-xxxx-build-config
branch
from
1a1c5c4 to
67e35a2
Compare
karkhaz
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We now pass
--cfg=kanito build scripts, which allow users to use constructs such asif cfg!(kani)to conditionally compile their build scripts.The build script may have logic that is not redundant to Kani, or even unsupported. Users can now change how their build works based on conditional compilation.
Resolved issues:
N/A
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? New test
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.