Add implementation for the #[kani::should_panic] attribute
#2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
commented
Mar 23, 2023
4 tasks
qinheping
reviewed
Mar 23, 2023
zhassan-aws
reviewed
Mar 23, 2023
|
Changed the comments around |
zhassan-aws
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Thanks @adpaco-aws! Looking forward to the documentation of this feature.
zhassan-aws
reviewed
Mar 24, 2023
zhassan-aws
reviewed
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds the implementation for the
#[kani::should_panic]attribute.Using the attribute will return the following results:
VERIFICATION:- FAILED (encountered no panics, but at least one was expected)if there were no failures.VERIFICATION:- FAILED (encountered failures other than panics, which were unexpected)if there were failures but not all them hadprop.property_class() == "assertion".VERIFICATION:- SUCCESSFUL (encountered one or more panics as expected)otherwise.Resolved issues:
Resolves #600
Related RFC:
#2272
Call-outs:
Testing:
How is this change tested? Existing tests + 6 new
uitestsIs this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.