Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propogate solver options into synthesizer #2320

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

qinheping
Copy link
Contributor

Description of changes:

As goto-synthesizer now support solver options (CBMC#7612). We should also propagate solver options into the synthesizer in Kani.

Resolved issues:

Resolves #ISSUE-NUMBER

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@qinheping qinheping requested a review from a team as a code owner March 27, 2023 20:24
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will need to wait for the next CBMC version bump before merging though.

@qinheping qinheping enabled auto-merge (squash) April 7, 2023 05:22
@qinheping qinheping merged commit 911b8b9 into model-checking:main Apr 7, 2023
karkhaz added a commit to karkhaz/kani that referenced this pull request Apr 19, 2023
* The Kani reference now includes an
  ["Attributes"](https://model-checking.github.io/kani/reference/attributes.html)
  section that describes each of the attributes available in Kani
  ([pull request](model-checking#2359)
by @adpaco-aws)
* Users' choice of SAT solver, specified by the `solver` attribute,
  is now propagated to the loop-contract synthesizer ([pull
  request](model-checking#2320) by
  @qinheping)
* Unit tests generated by the concrete playback feature now compile
  correctly when using `RUSTFLAGS="--cfg=kani"` ([pull
  request](model-checking#2353) by
@jaisnan)
* The Rust toolchain is updated to 2023-02-18 ([pull
  request](model-checking#2384) by
  @tautschnig)
@karkhaz karkhaz mentioned this pull request Apr 19, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants