Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow excluding packages from verification with --exclude #2399

Merged
merged 12 commits into from
Apr 21, 2023

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Apr 20, 2023

Description of changes:

This PR adds a --exclude option to Kani and allows excluding packages from verification (requested in #2375). It also adds validation for the packages passed to --package and --exclude so we print a user-friendly error with all unknown packages, instead of using expect as we were doing for arguments to --package.

Resolved issues:

Resolves #2375

Testing:

  • How is this change tested? Existing tests + 4 new ones.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner April 20, 2023 20:24
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adpaco-aws!

because it doesn't require --workspace (but it's implied anyway)

I'd prefer if we make --workspace required to keep the same interface as cargo build/test.

kani-driver/src/args.rs Outdated Show resolved Hide resolved
kani-driver/src/call_cargo.rs Outdated Show resolved Hide resolved
@adpaco-aws
Copy link
Contributor Author

I'd prefer if we make --workspace required to keep the same interface as cargo build/test.

Thanks, it's required now.

kani-driver/src/call_cargo.rs Outdated Show resolved Hide resolved
tests/cargo-ui/ws-package-exclude-unknown/src/main.rs Outdated Show resolved Hide resolved
tests/cargo-ui/ws-package-select/src/main.rs Outdated Show resolved Hide resolved
@adpaco-aws adpaco-aws enabled auto-merge (squash) April 21, 2023 14:03
@adpaco-aws adpaco-aws merged commit c7b38c2 into model-checking:main Apr 21, 2023
adpaco-aws added a commit to adpaco-aws/rmc that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: exclude crates from workspace at build time
2 participants