The unstable --c-lib option now requires -Z c-ffi to enable C-FFI support
#2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also give visibility to the compiler to whether this feature is enabled or not which is needed to avoid type mismatch issue (model-checking#1781).
adpaco-aws
reviewed
May 3, 2023
adpaco-aws
approved these changes
May 3, 2023
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This will also give visibility to the compiler to whether this feature is enabled or not which is needed to avoid type mismatch issue (#1781).
Resolved issues:
Related to #1781
Related RFC:
#2281
Call-outs:
-Z unstable-optionshere. This seems like over-killing having to use-Z c-ffiand-Z unstable-options.Option<&foo>does not decay to*fooin extern C mode #3 wasn't really testing anything. So I removed it and replaced it with a minimum test for theOption<&T>->*Tdecay.Testing:
How is this change tested? Modified tests
Is this a refactor change? Yes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.