Fix symtab json file removal and reduce regression scope #2447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This fixes a regression introduced in #2439 when write symtab json is enabled. We still need to take that into consideration and remove them if needed.
This change also simplifies the write symtab json regression to avoid the out of disk space issue we've been seeing since #2439.
Resolved issues:
N/A
Related RFC:
N/A.
Call-outs:
IMHO, we should consider removing support for the symtab json option given how much slower and costly it is. Besides, we haven't had any major problem with the goto approach that justifies keeping this code lingering.
Until then, we still want to have some test coverage in our regression, but keeping a full regression is costly and just not worth it at this point. Another possible way to fix the out of disk issue would be to clean the build folder after each test suite, but this would be a much more invasive change to our scripts.
Testing:
How is this change tested? CI
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.