Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symtab json file removal and reduce regression scope #2447

Merged
merged 3 commits into from
May 17, 2023

Conversation

celinval
Copy link
Contributor

Description of changes:

This fixes a regression introduced in #2439 when write symtab json is enabled. We still need to take that into consideration and remove them if needed.

This change also simplifies the write symtab json regression to avoid the out of disk space issue we've been seeing since #2439.

Resolved issues:

N/A

Related RFC:

N/A.

Call-outs:

IMHO, we should consider removing support for the symtab json option given how much slower and costly it is. Besides, we haven't had any major problem with the goto approach that justifies keeping this code lingering.

Until then, we still want to have some test coverage in our regression, but keeping a full regression is costly and just not worth it at this point. Another possible way to fix the out of disk issue would be to clean the build folder after each test suite, but this would be a much more invasive change to our scripts.

Testing:

  • How is this change tested? CI

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

This should also fix the out of space error from the symtab json
regression
@celinval celinval requested a review from a team as a code owner May 16, 2023 22:37
@celinval celinval merged commit 3d05d3f into model-checking:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants