Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static variable initialization when they have the same value #2469

Merged
merged 3 commits into from
May 25, 2023

Conversation

celinval
Copy link
Contributor

Description of changes:

We were incorrectly deduping the allocation of constant static variables. Static variables should each have their own memory allocation, and it should be correctly initialized.

Resolved issues:

Resolves #2455

Related RFC:

N/A

Call-outs:

The fix to this issue was basically the change to static_var.rs. The changes to operand.rs was a bit of cleanup to make it explicit that we should only try to dedupe constant allocations.

Testing:

  • How is this change tested? New test

  • Is this a refactor change? Not really

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

We were incorrectly deduping the allocation of constant static
variables.

Static variables should each have their own memory allocation, and it
should be correctly initialized.
@celinval celinval requested a review from a team as a code owner May 24, 2023 21:41
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@celinval celinval enabled auto-merge (squash) May 24, 2023 23:26
@celinval celinval merged commit 8348dc2 into model-checking:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False verification failures since version 0.28.0
2 participants