NOP concrete playback to type check during verification mode. #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
approved these changes
May 25, 2023
There was a problem hiding this comment.
Thanks @YoshikiTakashima. Do you mind adding a separate test instead?
|
new tests in 4575586. |
|
Something about this PR seems to be degrading performance. Might need a deep dive into benchcomp. |
No worries, the test that failed is very flaky. You should be safe. |
|
Rerunning didn't seem to fix it. The performance degradation might be something a bit more permanent... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds a NOP concrete playback function so that code inserted by the concrete playback feature that uses
concrete_playbackfunction still type checks during verification. Previously, this function was not available during verification, causing type fails during verification after playback code was injected.Resolved issues:
Resolves #2475
Related RFC:
Call-outs:
@YoshikiTakashima is not sure where the tests should go given that we want to test behavior when the kani is not in playback mode.
Testing:
How is this change tested?
tests/cargo-kani/simple-libIs this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.