Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to select the test targets #2491

Merged
merged 1 commit into from
May 30, 2023

Conversation

celinval
Copy link
Contributor

Description of changes:

Allow users to skip integration tests by selecting binaries or lib targets.

Resolved issues:

Resolves #2489

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

I still need to add a test

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

and avoid running integration tests.
@celinval celinval requested a review from a team as a code owner May 30, 2023 16:16
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@celinval celinval merged commit 24d4d88 into model-checking:main May 30, 2023
celinval added a commit that referenced this pull request May 30, 2023
This is a continuation from #2491. For completeness, I'm adding --bin option. I've also added a test for these options. Finally, I moved cargo specific arguments to its own module.
@celinval celinval mentioned this pull request Jun 5, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concrete Playback playback subcommand picks up regular unit tests and fails to compile
2 participants